Parse pyproject.toml to determine poetry use. #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: * The pyproject.toml file is for more than just poetry. This change addresses the need by: * Add test for use case where pyproject.toml is only used for black. * Add toml parser to package.json. * Update poetry.js to base poetry usage on whether or not the build system requires it. Fixes: #324
Merged
dschep
approved these changes
Apr 15, 2019
miketheman
added a commit
to miketheman/serverless-python-requirements
that referenced
this pull request
Feb 25, 2020
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs serverless#324 Refs serverless#344 Fixes serverless#400 Signed-off-by: Mike Fiedler <[email protected]>
miketheman
added a commit
to miketheman/serverless-python-requirements
that referenced
this pull request
Feb 25, 2020
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs serverless#324 Refs serverless#344 Fixes serverless#400 Signed-off-by: Mike Fiedler <[email protected]>
miketheman
added a commit
to miketheman/serverless-python-requirements
that referenced
this pull request
Feb 28, 2020
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs serverless#324 Refs serverless#344 Fixes serverless#400 Signed-off-by: Mike Fiedler <[email protected]>
bsamuel-ui
pushed a commit
that referenced
this pull request
May 4, 2020
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs #324 Refs #344 Fixes #400 Signed-off-by: Mike Fiedler <[email protected]>
Aubtin
pushed a commit
to Aubtin/serverless-python-requirements
that referenced
this pull request
Sep 16, 2020
During the evaluation in the package phase, we determine whether a `requirements.txt` file exists, or whether we need to generate one. Since the `pyproject.toml` file is used by poetry, but only if a stanza is contained inside the file, use the function `isPoetryProject()` along with the configuration value, thereby reducing the need for a project to have to declare a configuration override. Refs serverless#324 Refs serverless#344 Fixes serverless#400 Signed-off-by: Mike Fiedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
This change addresses the need by:
system requires it.
Fixes: #324